Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't call app.getPath('userData') before SDK init #797

Merged
merged 6 commits into from
Dec 5, 2023
Merged

fix: Don't call app.getPath('userData') before SDK init #797

merged 6 commits into from
Dec 5, 2023
+63 −13

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 4, 2023

Fixes #796

@timfish timfish changed the title fix: Don't app.getPath('userData') before SDK init fix: Don't call app.getPath('userData') before SDK init Dec 4, 2023
@timfish timfish requested a review from lforst December 4, 2023 15:54
AbhiPrasad
AbhiPrasad reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that validates this?

@timfish
Copy link
Collaborator Author

timfish commented Dec 5, 2023

The new test passes on my Windows machine but fails in CI 🤦🏻‍♂️

@timfish timfish merged commit e84a302 into getsentry:master Dec 5, 2023
@timfish timfish deleted the fix/lazt-getpath branch December 5, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst

@AbhiPrasad AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app.getPath('userData') is called before user calls init
3 participants
@timfish @lforst @AbhiPrasad