Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate tracingOrigins for tracePropagationTargets #703

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jul 18, 2023

This PR

  • Deprecates tracingOrigins in the Net integration
  • Adds support for tracePropagationTargets
  • Uses two LRUs like in the node http integration
  • Adds tests for the Net integration

The new tests are skiped for now since I've only been able to get them passing individually. As per the http tests, the instrumented function (net.request) needs to be replaced with the original function after each test but that appears to break something and further tests do not instrument.

@timfish timfish marked this pull request as ready for review July 19, 2023 09:38
@timfish timfish requested a review from AbhiPrasad July 19, 2023 10:54
@timfish timfish merged commit ecd978a into getsentry:master Jul 29, 2023
40 checks passed
@timfish timfish deleted the feat/use-tracing-client-options branch July 29, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants