Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron.net breadcrumbs are recorded for sending Sentry envelopes: #453

Open
timfish opened this issue Mar 30, 2022 · 3 comments
Open

electron.net breadcrumbs are recorded for sending Sentry envelopes: #453

timfish opened this issue Mar 30, 2022 · 3 comments

Comments

@timfish
Copy link
Collaborator

timfish commented Mar 30, 2022

Versions + Platform

  • SDK version - @sentry/electron@v3.x.y
  • Electron version - all
  • Platform - all

Description

electron.net breadcrumbs are recorded for sending Sentry envelopes:
image

This code attempts to stop this but isn't working for some reason:

if (url.match(/sentry_key/) || request.getHeader('x-sentry-auth')) {
return request;
}

@timfish
Copy link
Collaborator Author

timfish commented Mar 31, 2022

This is a strange one since I can't reproduce this locally 🤔

@AbhiPrasad
Copy link
Member

Seems like the request headers are only added for the store endpoint and node? https://github.com/getsentry/sentry-javascript/blob/db661b4ca60f5bce3ba3e587722b4b1a2643dc9b/packages/core/src/api.ts#L147-L167

Can we grab details about the dsn/URL from options and try to match that way?

@timfish
Copy link
Collaborator Author

timfish commented Mar 31, 2022

Seems like the request headers are only added for the store endpoint and node?

I ran the e2e tests and logged the headers at the test server and logged at the point where we bail out for Sentry requests and everything I saw was as expected

Can we grab details about the dsn/URL from options and try to match that way?

Yep, that might be more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants