Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Coose Your SDK" card items have cursor style inconsistencies #9990

Open
Lms24 opened this issue May 10, 2024 · 11 comments
Open

"Coose Your SDK" card items have cursor style inconsistencies #9990

Lms24 opened this issue May 10, 2024 · 11 comments
Assignees
Labels
Bug Type: Platform Issues about the platform & functionality of our docs

Comments

@Lms24
Copy link
Member

Lms24 commented May 10, 2024

Steps to Reproduce

  1. Go to landing page
  2. Hover over "Choose your SDK" link cards

Expected Result

The cursor becomes a pointer on the entire card

Actual Result

The cursor style is inconsistent (see screenshot):

  • Items with sub items/guides (e.g. JavaScript): Cursor only becomes pointer when hovering over text or arrow
  • Items without sub items/guides (e.g. Kotlin): Cursor becomes pointer over the entire card

Additional Info

image

@Lms24 Lms24 added Bug Type: Platform Issues about the platform & functionality of our docs labels May 10, 2024
@a-hariti
Copy link
Collaborator

This was intentional, the rationale behind it is that platforms with nothing to expand take you directly to the page,
others link there when clicking the text, and expand elsewhere

Do you think it would be better to have all links limited to visible text @Lms24 ?

@a-hariti a-hariti self-assigned this May 13, 2024
@Lms24
Copy link
Member Author

Lms24 commented May 13, 2024

I see, I kinda suspected something like this. I dont wanna dwell on this too much but to me it seems weird that there's so much dead space where a click doesn't do anything. If we can somehow solve that I think it'd be great but it doesn't necessarily have to be identical to the simple links

@a-hariti
Copy link
Collaborator

The cursor style gives a hint (the hand) when you're about to click on a link, that was the compromise I came up.

The alternative was to not have links on expandable headers and nest the platform link along with its guides, which looks weird

Javascript
  Javascript
  [other guides]

@Lms24
Copy link
Member Author

Lms24 commented May 13, 2024

random idea (please keep in mind, I'm no UI/UX expert); What if we really split the card?

image

Red: Link to base guide
Green: Open dropdown

wdyt?

@adinauer
Copy link
Member

adinauer commented May 13, 2024

Hey, It took me a while to figure out this behaviour of opening the generic "Java" docs via the text.
Maybe we could simply add the generic link to the list instead and open the dropdown regardless of where you click?

Edit: Ah that's what you suggested above @a-hariti in #9990 (comment)

I think that'd be easier to understand.

@a-hariti
Copy link
Collaborator

what about adding an arrow next the platform name to make it obvious that its a link, and add a tooltip to the rest of the card?
@Lms24

@mydea
Copy link
Member

mydea commented May 13, 2024

related to this, imho the arrows here are "wrong" - I would expect, when collapsed, that the arrow is v (down), and when expanded, it is ^? does that make sense?

@a-hariti
Copy link
Collaborator

currently it kinda mirrors the standard <details> element @mydea

@mydea
Copy link
Member

mydea commented May 13, 2024

currently it kinda mirrors the standard <details> element @mydea

Hmm, I see, there it is in front of the text though 🤔 no super strong feeling but overall it feels not 100% right to me (subjectively)

@a-hariti
Copy link
Collaborator

I meant in terms of caret direction @mydea

@a-hariti
Copy link
Collaborator

wyt @stephanie-anderson ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Platform Issues about the platform & functionality of our docs
Projects
Status: Backlog
Development

No branches or pull requests

4 participants