Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay SDK: document beforeAddRecordingEvent #7055

Closed
bruno-garcia opened this issue May 30, 2023 · 0 comments · Fixed by #7103
Closed

Replay SDK: document beforeAddRecordingEvent #7055

bruno-garcia opened this issue May 30, 2023 · 0 comments · Fixed by #7103
Assignees
@billyvg
Labels
Product Area: Replays Team: Replay team-replay

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented May 30, 2023 •
edited

The SDK received a new callback that allows users to modify (including scrub data) on the Replay Recording Event (rrweb).

This can be documented in the Privacy page. As an additional tool for developers to remove or modify data before it leaves the browser. For example, removing some breadcrumbs or network calls captured. See: getsentry/sentry-javascript#8124

Additionally, using URL scrubbing as an example, we can also mention a best-effort scrubbing in URLs happens in Sentry Relay (before data hits any storage). See: getsentry/relay#2143
@billyvg billyvg assigned billyvg and unassigned billyvg May 31, 2023
@billyvg billyvg mentioned this issue Jun 6, 2023
Merged
billyvg added a commit that referenced this issue Jun 6, 2023
@billyvg
feat(replays): Add documentation for beforeAddRecordingEvent
1c42a98 
Closes #7055
billyvg added a commit that referenced this issue Jun 19, 2023
@billyvg
feat(replays): Add documentation for beforeAddRecordingEvent
24eff0f 
Closes #7055
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
shanamatthews pushed a commit that referenced this issue Jul 31, 2023
@billyvg @lizokm
@ryan953 @bruno-garcia @mydea @shanamatthews
feat(replays): Add documentation for beforeAddRecordingEvent (#7103)
68475a7 
Closes #7055

Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@billyvg billyvg

Labels
Product Area: Replays Team: Replay team-replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replays): Add documentation for beforeAddRecordingEvent getsentry/sentry-docs
2 participants
@billyvg @bruno-garcia