-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sourceContext option to make build work. #8497
Disable sourceContext option to make build work. #8497
Conversation
When setting this option to true, `authToken`, `org`, and `project` settings also need to be set. Documentation for setting them exists in the source context documentation.
@Glyphack is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Hi @adinauer I tried to add the resolution in the issue getsentry/sentry-android-gradle-plugin#546 to docs here. Could you take a look since you have more context about this feature? I'm not totally sure this PR will fix that issue because the discussion drifted away from the source upload to code mappings and was left there. But this adjustments are useful for others trying to use this feature. |
Thanks for the PR @Glyphack. I'd prefer to keep the sample with I feel like the sentence you added should go into troubleshooting but in general makes sense to add it to the docs. Thank you! We'll discuss internally and update the PR if you don't mind. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of small grammar tweaks.
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Thanks again @Glyphack for the contribution! |
Changes
org
,project
, andauthToken
so in result the config you copy from the docs fail. I think adding the comment to enable it after reading the docs would communicate that some additional steps are needed for this feature.Fix: getsentry/sentry-android-gradle-plugin#546
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources