Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump AGP and Gradle versions #428

Merged
merged 22 commits into from Mar 20, 2023
Merged

Bump AGP and Gradle versions #428

merged 22 commits into from Mar 20, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 17, 2023 •
edited

馃摐 Description

  • Switched Java version to 17 locally and on CI
  • Bumped AGP and Gradle versions for test matrices
  • Fixed tests not working with Gradle 8+
  • Vendored aar2jar plugin as it's unmaintained and is not compatible with Gradle 8

馃挕 Motivation and Context

Closes #445

馃挌 How did you test it?

Manually and automated

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@romtsn romtsn marked this pull request as ready for review March 17, 2023 22:53
@romtsn romtsn requested a review from markushi as a code owner March 17, 2023 22:53
markushi
markushi approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit c31a657 into main Mar 20, 2023
19 checks passed
@romtsn romtsn deleted the chore/bump-versions branch March 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task uses this output of task without declaring an explicit or implicit dependency
2 participants
@romtsn @markushi