Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note on action-release@v2 #258

Closed
andreiborza opened this issue Feb 11, 2025 · 12 comments
Closed

Note on action-release@v2 #258

andreiborza opened this issue Feb 11, 2025 · 12 comments

Comments

@andreiborza
Copy link
Member

We recently created and pushed a branch named v2. This was not meant to be a release but dependabot treated it as such and some users upgraded to v2 as a result. To avoid breaking users that already upgraded, we published a v2 major with no user facing changes.

Going forward, v1 will continue to get features and patches, v2 will not go beyond 2.0.0 but its tag will continue to be updated to match v1.

Breaking changes will be introduced with v3.

We recommend pinning the action at getsentry/action-release@v1 until v3 is released.
@andreiborza andreiborza pinned this issue Feb 11, 2025
@andreiborza andreiborza mentioned this issue Feb 11, 2025
Closed
@bocajji
Copy link

bocajji commented Feb 11, 2025

Pointing to v1 was breaking for us with the following:

Error: Cannot find module '@sentry/cli'
Require stack:
- /home/runner/work/_actions/getsentry/action-release/v1/dist/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at 65461 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123[188](https://github.com/empion-io/empion-platform-frontend/actions/runs/13264297270/job/37028040697#step:7:193):18)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43)
    at 56733 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:122647:31)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43)
    at 70399 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:122715:15)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js'
  ]
}

Pointing to v2 resolved the issue however. Just in case anyone is facing the same problem. But noted that incoming changes will be on v1.

@andreiborza
Copy link
Member Author

@bocajji could you please paste logs from the action run step that ran our action? I tried this out in a sample repo of mine and didn't run into it using uses: getsentry/action-release@v1.

@ttrevorr
Copy link

same issue.

2025-02-12T06:46:59.2426696Z ##[group]Run getsentry/action-release@v1
2025-02-12T06:46:59.2427172Z with:
2025-02-12T06:46:59.2427476Z   environment: stage
2025-02-12T06:46:59.2427801Z   sourcemaps: ./dist
2025-02-12T06:46:59.2428120Z   inject: true
2025-02-12T06:46:59.2428424Z   finalize: true
2025-02-12T06:46:59.2428732Z env:
2025-02-12T06:46:59.2430263Z   SENTRY_AUTH_TOKEN: ***
2025-02-12T06:46:59.2430618Z   SENTRY_ORG: <REDACTED>
2025-02-12T06:46:59.2431139Z   SENTRY_PROJECT: <REDACTED>
2025-02-12T06:46:59.2431499Z   NODE_ENV: production
2025-02-12T06:46:59.2431821Z ##[endgroup]
2025-02-12T06:46:59.2555011Z ##[group]Run git config --global --add safe.directory /home/runner/work/***/***
2025-02-12T06:46:59.2555861Z �[36;1mgit config --global --add safe.directory /home/runner/work/***/***�[0m
2025-02-12T06:46:59.2592256Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-12T06:46:59.2592767Z env:
2025-02-12T06:46:59.2594303Z   SENTRY_AUTH_TOKEN: ***
2025-02-12T06:46:59.2594697Z   SENTRY_ORG: <REDACTED>
2025-02-12T06:46:59.2595038Z   SENTRY_PROJECT: <REDACTED>
2025-02-12T06:46:59.2595398Z   NODE_ENV: production
2025-02-12T06:46:59.2595733Z ##[endgroup]
2025-02-12T06:46:59.2729775Z ##[group]Run echo "NODE_VERSION=$(node -v 2>/dev/null || echo '')" >> $GITHUB_ENV
2025-02-12T06:46:59.2730495Z �[36;1mecho "NODE_VERSION=$(node -v 2>/dev/null || echo '')" >> $GITHUB_ENV�[0m
2025-02-12T06:46:59.2764159Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-12T06:46:59.2764638Z env:
2025-02-12T06:46:59.2766243Z   SENTRY_AUTH_TOKEN: ***
2025-02-12T06:46:59.2766592Z   SENTRY_ORG: <REDACTED>
2025-02-12T06:46:59.2766929Z   SENTRY_PROJECT: <REDACTED>
2025-02-12T06:46:59.2767288Z   NODE_ENV: production
2025-02-12T06:46:59.2767608Z ##[endgroup]
2025-02-12T06:46:59.2903767Z ##[group]Run npm install --save-dev --no-package-lock @sentry/cli@^2.4
2025-02-12T06:46:59.2904457Z �[36;1mnpm install --save-dev --no-package-lock @sentry/cli@^2.4�[0m
2025-02-12T06:46:59.2936533Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-12T06:46:59.2937023Z env:
2025-02-12T06:46:59.2938567Z   SENTRY_AUTH_TOKEN: ***
2025-02-12T06:46:59.2938916Z   SENTRY_ORG: <REDACTED>
2025-02-12T06:46:59.2939252Z   SENTRY_PROJECT: <REDACTED>
2025-02-12T06:46:59.2939608Z   NODE_ENV: production
2025-02-12T06:46:59.2939936Z   NODE_VERSION: v22.14.0
2025-02-12T06:46:59.2940269Z ##[endgroup]
2025-02-12T06:47:31.3639657Z 
2025-02-12T06:47:31.3652270Z added 85 packages, and audited 86 packages in 32s
2025-02-12T06:47:31.3652704Z 
2025-02-12T06:47:31.3652975Z 4 packages are looking for funding
2025-02-12T06:47:31.3653406Z   run `npm fund` for details
2025-02-12T06:47:31.3653643Z 
2025-02-12T06:47:31.3653832Z found 0 vulnerabilities
2025-02-12T06:47:31.4081117Z ##[group]Run npm run start
2025-02-12T06:47:31.4081728Z �[36;1mnpm run start�[0m
2025-02-12T06:47:31.4120818Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-02-12T06:47:31.4121614Z env:
2025-02-12T06:47:31.4123162Z   SENTRY_AUTH_TOKEN: ***
2025-02-12T06:47:31.4123534Z   SENTRY_ORG: <REDACTED>
2025-02-12T06:47:31.4123878Z   SENTRY_PROJECT: <REDACTED>
2025-02-12T06:47:31.4124238Z   NODE_ENV: production
2025-02-12T06:47:31.4124575Z   NODE_VERSION: v22.14.0
2025-02-12T06:47:31.4124918Z   INPUT_ENVIRONMENT: stage
2025-02-12T06:47:31.4125274Z   INPUT_INJECT: true
2025-02-12T06:47:31.4125685Z   INPUT_SOURCEMAPS: ./dist
2025-02-12T06:47:31.4126030Z   INPUT_DIST: 
2025-02-12T06:47:31.4126344Z   INPUT_FINALIZE: true
2025-02-12T06:47:31.4126681Z   INPUT_IGNORE_MISSING: 
2025-02-12T06:47:31.4127023Z   INPUT_IGNORE_EMPTY: 
2025-02-12T06:47:31.4127347Z   INPUT_STARTED_AT: 
2025-02-12T06:47:31.4127667Z   INPUT_VERSION: 
2025-02-12T06:47:31.4127987Z   INPUT_VERSION_PREFIX: 
2025-02-12T06:47:31.4128331Z   INPUT_SET_COMMITS: 
2025-02-12T06:47:31.4128656Z   INPUT_PROJECTS: 
2025-02-12T06:47:31.4128972Z   INPUT_URL_PREFIX: 
2025-02-12T06:47:31.4129690Z   INPUT_STRIP_COMMON_PREFIX: 
2025-02-12T06:47:31.4130068Z   INPUT_WORKING_DIRECTORY: 
2025-02-12T06:47:31.4130711Z   INPUT_DISABLE_TELEMETRY: 
2025-02-12T06:47:31.4131302Z   INPUT_DISABLE_SAFE_DIRECTORY: 
2025-02-12T06:47:31.4131676Z ##[endgroup]
2025-02-12T06:47:31.5431031Z 
2025-02-12T06:47:31.5432472Z > action-release@1.10.4 start
2025-02-12T06:47:31.5433683Z > node dist/index.js
2025-02-12T06:47:31.5433906Z 
2025-02-12T06:47:31.7982204Z node:internal/modules/cjs/loader:1228
2025-02-12T06:47:31.7982696Z   throw err;
2025-02-12T06:47:31.7982991Z   ^
2025-02-12T06:47:31.7983155Z 
2025-02-12T06:47:31.7983400Z Error: Cannot find module '@sentry/cli'
2025-02-12T06:47:31.7983819Z Require stack:
2025-02-12T06:47:31.7984401Z - /home/runner/work/_actions/getsentry/action-release/v1/dist/index.js
2025-02-12T06:47:31.7985197Z     at Function._resolveFilename (node:internal/modules/cjs/loader:1225:15)
2025-02-12T06:47:31.7985900Z     at Function._load (node:internal/modules/cjs/loader:1055:27)
2025-02-12T06:47:31.7986600Z     at TracingChannel.traceSync (node:diagnostics_channel:322:14)
2025-02-12T06:47:31.7987268Z     at wrapModuleLoad (node:internal/modules/cjs/loader:220:24)
2025-02-12T06:47:31.7987913Z     at Module.require (node:internal/modules/cjs/loader:1311:12)
2025-02-12T06:47:31.7988507Z     at require (node:internal/modules/helpers:136:16)
2025-02-12T06:47:31.7989244Z     at 65461 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123188:18)
2025-02-12T06:47:31.7990233Z     at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43)
2025-02-12T06:47:31.7995567Z     at 56733 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:122647:31)
2025-02-12T06:47:31.7996629Z     at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43) {
2025-02-12T06:47:31.7997339Z   code: 'MODULE_NOT_FOUND',
2025-02-12T06:47:31.7997695Z   requireStack: [
2025-02-12T06:47:31.7998225Z     '/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js'
2025-02-12T06:47:31.7998767Z   ]
2025-02-12T06:47:31.7999065Z }
2025-02-12T06:47:31.7999237Z 
2025-02-12T06:47:31.7999375Z Node.js v22.14.0
2025-02-12T06:47:31.8106154Z ##[error]Process completed with exit code 1.

@FelipeMaroni
Copy link

FelipeMaroni commented Feb 13, 2025 •
edited
Loading

Same issue for us, we tried we tried to set a specific version but it seems all versions 1.10+ are broken after last changes

Error: Cannot find module '@sentry/cli'
Require stack:
- /home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at 65461 (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:123188:18)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:123614:43)
    at 56733 (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:122647:31)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:123614:43)
    at 70399 (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:122715:15)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js:123614:43) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/getsentry/action-release/v1.10.3/dist/index.js'
  ]
}

@JoaoPauloCMarra
Copy link

same here

V2

Error: Cannot find module '@sentry/cli'
Require stack:
- /home/runner/work/_actions/getsentry/action-release/v2/dist/index.js

V1

Error: Cannot find module '@sentry/cli'
Require stack:
- /home/runner/work/_actions/getsentry/action-release/v1/dist/index.js

@andreiborza
Copy link
Member Author

Thanks for the reports, will take a look.

@FozzieHi FozzieHi mentioned this issue Feb 23, 2025
Closed
@tomodwyer tomodwyer mentioned this issue Feb 25, 2025
Closed
@steveatkoan
Copy link

same here. Oddly it works for a non production build, but fails for production when using getsentry/action-release@v1

Run npm run start
  npm run start
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    NODE_ENV: production
    AWS_DEFAULT_REGION: eu-west-1
    AWS_REGION: eu-west-1
    AWS_ACCESS_KEY_ID: ***
    AWS_SECRET_ACCESS_KEY: ***
    AWS_SESSION_TOKEN: ***
    NODE_VERSION: v22.13.1
    SENTRY_AUTH_TOKEN: ***
    SENTRY_ORG: koan-7j
    SENTRY_PROJECT: brainhealth-web
    INPUT_ENVIRONMENT: production
    INPUT_INJECT: 
    INPUT_SOURCEMAPS: ./dist
    INPUT_DIST: 
    INPUT_FINALIZE: true
    INPUT_IGNORE_MISSING: true
    INPUT_IGNORE_EMPTY: true
    INPUT_STARTED_AT: 
    INPUT_VERSION: 444
    INPUT_VERSION_PREFIX: 
    INPUT_SET_COMMITS: 
    INPUT_PROJECTS: 
    INPUT_URL_PREFIX: 
    INPUT_STRIP_COMMON_PREFIX: 
    INPUT_WORKING_DIRECTORY: 
    INPUT_DISABLE_TELEMETRY: 
    INPUT_DISABLE_SAFE_DIRECTORY: 
> action-release@1.10.5 start
> node dist/index.js
node:internal/modules/cjs/loader:1247
  throw err;
  ^
Error: Cannot find module '@sentry/cli'
Require stack:
- /home/runner/work/_actions/getsentry/action-release/v1/dist/index.js
    at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
    at Function._load (node:internal/modules/cjs/loader:1070:27)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at require (node:internal/modules/helpers:136:16)
    at 65461 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123188:18)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43)
    at 5[67](https://github.com/koandata/brainhealth-web/actions/runs/13536688685/job/37829781419#step:13:71)33 (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:122647:31)
    at __nccwpck_require__ (/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js:123614:43) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/getsentry/action-release/v1/dist/index.js'
  ]
}
Node.js v22.13.1
Error: Process completed with exit code 1.

@andreiborza
Copy link
Member Author

@steveatkoan that's odd. Could you show logs from the action steps please?

Also, I reworked the action into a hybrid approach where on Linux, we make use of docker to behave more like <= 1.9.0 did.
I'd love if you could try it out and see how things are working for you with it. To try it use:

uses: getsentry/action-release@ab/multiarch-docker

@steveatkoan
Copy link

@andreiborza thanks. That worked!
Should I continue to use this branch until v3 is released?

@andreiborza
Copy link
Member Author

@steveatkoan no, I'll release this today as v1.11.0.

@andreiborza
Copy link
Member Author

We published v1.11.0 which brings improvements in runtime and compatibility on Linux runners while still supporting Mac OS and Windows runners.

Please pin your action to @v1

uses: getsentry/action-release@v1

If issues persist, please don't hesitate to open up another issue here on GitHub.

@andreiborza
Copy link
Member Author

andreiborza commented Mar 3, 2025 •
edited
Loading

v3.0.0 has been released. If you encounter issues, please feel free to file a new issue.

@andreiborza andreiborza unpinned this issue Mar 3, 2025
This was referenced Mar 7, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@JoaoPauloCMarra @ttrevorr @bocajji @steveatkoan @FelipeMaroni @andreiborza