Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Remove warnings #7350

Merged
merged 1 commit into from Feb 17, 2024

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Feb 16, 2024

Cryptography >= 40.0.0 introduces a new property, not_valid_before_utc, that will replace the old not_valid_before-property. This PR supports both properties (and therefore all versions of cryptography).

This PR also:

  • updates some CI dependencies
  • tests these changes with an older version of cryptography
  • improves an EC2 test to reduce the chances that it finds a resources created by other tests.
  • fixes some pytest warnings since tests (methods that start with test_) should not return anything

@bblommers bblommers added this to the 5.0.2 milestone Feb 16, 2024
@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Feb 16, 2024
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Feb 16, 2024
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Feb 16, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9aef694) 95.88% compared to head (abf59a2) 95.86%.
Report is 23 commits behind head on master.

Files Patch % Lines
moto/acm/models.py 71.42% 4 Missing ⚠️
moto/acmpca/models.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7350      +/-   ##
==========================================
- Coverage   95.88%   95.86%   -0.03%     
==========================================
  Files         843      843              
  Lines       82578    82838     +260     
==========================================
+ Hits        79178    79410     +232     
- Misses       3400     3428      +28     
Flag Coverage Δ
servertests 32.55% <9.09%> (+0.03%) ⬆️
unittests 95.82% <63.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 8561740 into getmoto:master Feb 17, 2024
63 of 64 checks passed
@bblommers bblommers deleted the techdebt/remove-warnings branch February 17, 2024 08:39
Copy link
Contributor

This is now part of moto >= 5.0.2.dev26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant