Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: RDS Proxy #7329

Merged
merged 5 commits into from Feb 16, 2024
Merged

Feature: RDS Proxy #7329

merged 5 commits into from Feb 16, 2024

Conversation

JoshLevyMN
Copy link
Contributor

Adds initial support for RDS Proxy, including create, describe, and tagging.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoshLevyMN! Please see my comments.

It looks like the linter is failing as well: https://github.com/getmoto/moto/actions/runs/7849632093/job/21423405368?pr=7329

moto/rds/models.py Outdated Show resolved Hide resolved
moto/rds/models.py Outdated Show resolved Hide resolved
moto/rds/models.py Outdated Show resolved Hide resolved
moto/rds/models.py Outdated Show resolved Hide resolved
moto/rds/models.py Outdated Show resolved Hide resolved
moto/rds/responses.py Outdated Show resolved Hide resolved
@JoshLevyMN
Copy link
Contributor Author

Hi @bblommers, thanks for the feedback, it should all be addressed with the latest commit.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (9aef694) 95.88% compared to head (db7acc0) 95.86%.
Report is 19 commits behind head on master.

Files Patch % Lines
moto/rds/models.py 75.32% 19 Missing ⚠️
moto/rds/exceptions.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7329      +/-   ##
==========================================
- Coverage   95.88%   95.86%   -0.02%     
==========================================
  Files         843      843              
  Lines       82578    82761     +183     
==========================================
+ Hits        79178    79341     +163     
- Misses       3400     3420      +20     
Flag Coverage Δ
servertests 32.49% <18.42%> (-0.03%) ⬇️
unittests 95.83% <82.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers added this to the 5.0.2 milestone Feb 16, 2024
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you for adding these features to Moto @JoshLevyMN!

@bblommers bblommers merged commit 59248f3 into getmoto:master Feb 16, 2024
38 of 39 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.2.dev23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants