Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: UpdateExpressions can contain a new-line #7128

Merged
merged 1 commit into from Dec 16, 2023

Conversation

bblommers
Copy link
Collaborator

Fixes #7127

Behaviour is now verified against AWS

@bblommers bblommers added this to the 4.2.12 milestone Dec 15, 2023
@@ -17,6 +17,7 @@ class Token:
CLOSE_ROUND_BRACKET = ")"
COMMA = ","
SPACE = " "
NEW_LINE = "\n"
DOT = "."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated with the issue, but I noticed SPACE_SIGN on line 14 and 28 can be deleted since they aren't used anywhere throughout the moto repository (it's a duplicate of SPACE).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @abbasyadollahi - I've removed the field. Thanks for the review!

@bblommers bblommers merged commit 2228f07 into getmoto:master Dec 16, 2023
29 of 30 checks passed
@bblommers bblommers deleted the dynamodb-update-expr-new-line branch December 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB UpdateExpression with newlines raises InvalidTokenException
2 participants