Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM: Performance improvements #7123

Merged

Conversation

bblommers
Copy link
Collaborator

fromisoformat is a more performant way to get a date-object from a string.

Using choices(.., k=x) is the builtin way to loop over choice x time - and also happens to more performant.

@bblommers bblommers added this to the 4.2.12 milestone Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a26072e) 95.88% compared to head (9606c5c) 95.88%.
Report is 4 commits behind head on master.

Files Patch % Lines
moto/s3/models.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7123   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         834      834           
  Lines       82179    82202   +23     
=======================================
+ Hits        78796    78819   +23     
  Misses       3383     3383           
Flag Coverage Δ
servertests 35.79% <15.15%> (-0.01%) ⬇️
unittests 95.82% <96.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 7227326 into getmoto:master Dec 14, 2023
32 checks passed
@bblommers bblommers deleted the techdebt/iam-performance-improvements branch December 14, 2023 11:50
Copy link
Contributor

This is now part of moto >= 4.2.12.dev24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant