EC2: Cross-account VPC peering connections #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
force-pushed
the
vpc-peering-cross-account-region
branch
from
2bb5326
to
cf3498b
Compare
bblommers
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Looks like the linter is failing: https://github.com/getmoto/moto/actions/runs/6224588248/job/16893138639
All tests that now patch os.environ will have to be skipped in ServerMode, otherwise they'll fail.
The logic itself looks good to me!
viren-nadkarni
force-pushed
the
vpc-peering-cross-account-region
branch
from
cf3498b
to
070d719
Compare
bblommers
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS allows VPCs to be peered as long as their CIDR ranges do not overlap. Peering can happen within the same account/region or cross-account/region.
#2195 added VPC peering support across-regions.
This PR introduces VPC peering support across-accounts.
Exisiting tests have been parametrised to run all assertions within the same account and across accounts.
Closes: localstack/localstack#8550