Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entrypoint block types to be optional #8

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

Bo98
Copy link
Contributor

@Bo98 Bo98 commented Mar 11, 2025

Noticed that these were incorrect and were not nilable like all of the other block signatures. These can be nil because KubeDSL::DSLObject's initializer accepts a nil block:

T::Sig::WithoutRuntime.sig { params(block: T.nilable(T.proc.bind(::KubeDSL::DSLObject).void)).void }
def initialize(&block)
instance_eval(&block) if block
end

Copy link
Member

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, nice catch 👍

@camertron camertron merged commit fe4d0c2 into getkuby:master Mar 19, 2025
@Bo98 Bo98 deleted the entrypoint-nil-proc branch March 19, 2025 17:13
@camertron
Copy link
Member

Published in v0.8.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants