openapi3: delete origin keys only when IncludeOrigin=true #1055
+108
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but please rebase now that I merged #1057 |
reuvenharrison
changed the title
|
@fenollp the PR is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1051.
The problem was caused because openapi3 removed
originkeys fromSchema.Propertiesand other map-based types including allComponentstypes.To fix this I changed the behavior to only delete
originkeys whenIncludeOriginis set to true.Note that this required moving
Loader.IncludeOriginto the global scope so that map unmarshalling functions can access it.For example:
Schemas.UnmarshalJSON->unmarshalStringMapP->popOriginwhich accessesIncludeOrigin