Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth - wrong logout link #1093

Open
diginote opened this issue Oct 1, 2022 · 2 comments
Open

OAuth - wrong logout link #1093

diginote opened this issue Oct 1, 2022 · 2 comments
Labels
type: bug something is broken, we need to fix it

Comments

@diginote
Copy link

diginote commented Oct 1, 2022

Fider Self Hosted
latest docker stable version: getfider/fider:stable

Describe the bug
No Logout URL definition for OAuth-Providers. When user click signout you need to call a link of the OAuth-Provider with a redirct to the domain where fider is accessable. Currently fider do not have an option to define an logout URL in then OAuth-Provider settings und the logout is only locally. The session on the OAuth-Provider is not closed. Therfore you are not really logged out. When you click on the login button you will be redirected to the OAuth-Provider where your session is active und you will be immediately redirected to fider again without an input of your credentials.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Authentication-Settings an configure keycloak as OAuth-Provider
  2. login with your OAuth credentials
  3. logout
  4. try to login again -> you do not have to input your credential, because your last session on OAuth-Provider was not properly closed und is reused.

Expected behavior
When I logout you have to call the OAuth-Provider endpoint with a redirect url to finder domain. For that you need to define that endpoint in the Authentication-Settings. Currently there is no such setting and the logout link is wrong.

@diginote diginote added the type: bug something is broken, we need to fix it label Oct 1, 2022
@diginote
Copy link
Author

diginote commented Oct 2, 2022

An openid connect logout is described here: https://www.keycloak.org/2022/04/keycloak-1800-released#_openid_connect_logout

@Loapu
Copy link

Loapu commented Feb 24, 2023

I would also love to see this implemented, as it is rather tedious to not get logged out of the OAuth session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something is broken, we need to fix it
Projects
None yet
Development

No branches or pull requests

2 participants