Accommodate bug fix to pre-commit hook fail_fast #513
Labels
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
What's the issue?
When setting up the pre-commit config, we relied on some behaviour contrary to the documentation for hook
fail_fast
. This turned out to be a bug that has now been fixed in v3.7.0 pre-commit/pre-commit#3167. This means that the pylint hook is now only skipped if ruff fails, rather than if any previous hook fails.We would like to keep this behaviour because pylint is a slow hook and there is some duplication of functionality between ruff and pylint.
Thus, the action to be taken is to update the comment on
fail_fast
in the ruff hook to reflect this new behaviour. Also, update the dependencies to require at least v3.7.0 of pre-commit.The text was updated successfully, but these errors were encountered: