Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate bug fix to pre-commit hook fail_fast #513

Closed
tp832944 opened this issue Mar 25, 2024 · 0 comments · Fixed by #514 or #526
Closed

Accommodate bug fix to pre-commit hook fail_fast #513

tp832944 opened this issue Mar 25, 2024 · 0 comments · Fixed by #514 or #526
Assignees
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Comments

@tp832944
Copy link
Contributor

What's the issue?

When setting up the pre-commit config, we relied on some behaviour contrary to the documentation for hook fail_fast. This turned out to be a bug that has now been fixed in v3.7.0 pre-commit/pre-commit#3167. This means that the pylint hook is now only skipped if ruff fails, rather than if any previous hook fails.

We would like to keep this behaviour because pylint is a slow hook and there is some duplication of functionality between ruff and pylint.

Thus, the action to be taken is to update the comment on fail_fast in the ruff hook to reflect this new behaviour. Also, update the dependencies to require at least v3.7.0 of pre-commit.

@tp832944 tp832944 added new Something yet to be discussed by development team documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file and removed new Something yet to be discussed by development team labels Mar 25, 2024
@tp832944 tp832944 self-assigned this Mar 25, 2024
tp832944 added a commit that referenced this issue Mar 28, 2024
@tp832944 tp832944 linked a pull request Mar 28, 2024 that will close this issue
9 tasks
tp832944 added a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
1 participant