Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-google-gtag): Add plugin options #37953

Merged
merged 6 commits into from Apr 18, 2023
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Apr 17, 2023

Description

#37947 surfaced that we don't make it obvious that trackingIds is required. This PR adds pluginOptionsSchema to gatsby-plugin-google-gtag.

Documentation

Updated the README

Tests

Added unit tests

Related Issues

#37947

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 17, 2023
@LekoArts LekoArts added topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 17, 2023
@LekoArts LekoArts marked this pull request as ready for review April 17, 2023 13:59
@pieh pieh merged commit c1f0bbf into master Apr 18, 2023
31 checks passed
@pieh pieh deleted the gtag-plugin-options branch April 18, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants