feat(gatsby): Partial hydration router integration #36616
Merged
+225
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: core
Base automatically changed from
feat/partial-hydration-error-handling
to
feat/partial-hydration-webpack
September 20, 2022 08:35
tyhopp
force-pushed
the
feat/partial-hydration-router-integration
branch
from
6ad0de8 to
74ec47b
Compare
tyhopp
force-pushed
the
feat/partial-hydration-router-integration
branch
from
5b4aaf8 to
5b5880f
Compare
tyhopp
commented
Sep 29, 2022
| import { | ||
| navigate as reachNavigate, | ||
| globalHistory, | ||
| } from "@gatsbyjs/reach-router" |
There was a problem hiding this comment.
Exported from reach router index in v1 and v2
tyhopp
commented
Sep 29, 2022
| @@ -9,7 +9,7 @@ import { grabMatchParams } from "./find-path" | |||
| import syncRequires from "$virtual/ssr-sync-requires" | |||
|
|
|||
| import { RouteAnnouncerProps } from "./route-announcer-props" | |||
| import { ServerLocation, Router, isRedirect } from "@reach/router" | |||
| import { ServerLocation, Router, isRedirect } from "@gatsbyjs/reach-router" | |||
There was a problem hiding this comment.
This uses our alias @reach/router > @gatsbyjs/reach-router, clarify import now since we'll remove the alias in Gatsby 5
pieh
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use router during partial hydration rendering:
locationavailable as props in page componentsuseLocationhook available in childrenpathPrefixfeatureDocumentation
N/A
Related Issues
[sc-55227]