chore: update eslint to fix linting issues (#29988)

* chore: update eslint to fix linting issues

* cleanup

* remove /

* Update packages/gatsby/src/commands/serve.ts

Co-authored-by: Matt Kane <matt@gatsbyjs.com>

* update config

* update circle to keep babel-preset-gatsby-package so we can use it in
our babel config

* fix unit tests

* fix snapshot

* fix thigns

* update gatsby-node

Co-authored-by: Matt Kane <matt@gatsbyjs.com>

Author: wardpeet

.babelrc.js

@@ -1,13 +1,13 @@
-let ignore = [`**/dist`]
+const ignore = [`**/dist`]
 
 // Jest needs to compile this code, but generally we don't want this copied
 // to output folders
-if (process.env.NODE_ENV !== `test`) {
-  ignore.push(`**/__tests__`)
-}
+// if (process.env.NODE_ENV !== `test`) {
+//   ignore.push(`**/__tests__`)
+// }
 
 module.exports = {
   sourceMaps: true,
-  presets: ["babel-preset-gatsby-package"],
+  presets: [`babel-preset-gatsby-package`],
   ignore,
 }

.circleci/config.yml

@@ -200,7 +200,7 @@ jobs:
       - run:
           name: "remove workspaces from package.json"
           command: |
-            sed -i ':a;N;$!ba;s/,\n\s*"workspaces":\s\[[^]]*]//g' package.json
+            sed -i ':a;N;$!ba;s/,\n\s*"workspaces":\s\[[^]]*]/,"workspaces":\["packages\/babel-preset-gatsby"\]/g' package.json
       - <<: *install_node_modules
       - run: yarn lint:code
       - run: yarn lint:docs