Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repo compliant #900

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Make repo compliant #900

merged 1 commit into from
Mar 19, 2024

Conversation

RaphaelVogel
Copy link
Member

What this PR does / why we need it:

  • Deleted NOTICE.md file
  • Updated CONTRIBUTING.md file
  • Created/Updated LICENSE file
    • Deleted LICENSE.md file
  • Created/Updated .reuse/dep5 file
  • Created/Updated LICENSES folder
  • Added badge for reuse compliance in README.md file and registered repo with REUSE API
  • License/Copyright header replacement for 'non-go' files
    • Makefile
    • .ci/test
    • .ci/build
    • .ci/check
    • hack/non_gardener_local_setup.sh
    • hack/generate-code
    • hack/gardener_local_setup.sh
    • hack/non_gardener_local_restore.sh
    • hack/gardener_local_restore.sh
    • hack/tools.mk
    • hack/api-reference/generate-spec-doc.sh
  • License/Copyright header replacement for 'go' files
    • hack/tools.go
    • hack/api-reference/template/tools.go
    • pkg/apis/machine/doc.go
    • pkg/apis/machine/install/install.go
    • pkg/apis/machine/v1alpha1/shared_types.go
    • pkg/apis/machine/v1alpha1/machine_types.go
    • pkg/apis/machine/v1alpha1/machineset_types.go
    • pkg/apis/machine/v1alpha1/machineclass_types.go
    • pkg/apis/machine/v1alpha1/doc.go
    • pkg/apis/machine/v1alpha1/machinedeployment_types.go
    • pkg/apis/machine/validation/validation_suite_test.go
    • pkg/test/integration/common/framework.go
    • pkg/test/integration/common/helpers/resources_tracker_interface.go
    • pkg/test/integration/common/helpers/machine_resources.go
    • pkg/test/integration/common/helpers/handling_files.go
    • pkg/test/integration/common/helpers/cluster.go
    • pkg/test/integration/common/helpers/nodes.go
    • pkg/test/utils/matchers/kubernetes_errors.go
    • pkg/test/utils/matchers/deep.go
    • pkg/test/utils/matchers/matchers.go
    • pkg/util/provider/machinecontroller/machine_safety_util_test.go
    • pkg/util/provider/machinecontroller/machine_safety_util.go
    • pkg/util/provider/drain/drain_suite_test.go
    • pkg/util/time/time_suite_test.go
    • pkg/util/annotations/annotations_suite_test.go
    • pkg/util/worker/worker.go
    • pkg/openapi/doc.go
    • pkg/controller/autoscaler/types.go
    • pkg/metrics/metrics.go
    • pkg/options/types.go
    • pkg/apis/machine/register.go
    • pkg/apis/machine/types.go
    • pkg/apis/machine/v1alpha1/register.go
    • pkg/apis/machine/validation/machineset.go
    • pkg/apis/machine/validation/machine.go
    • pkg/apis/machine/validation/machinedeployment.go
    • pkg/util/backoff/backoff_suite_test.go
    • pkg/util/backoff/wait_test.go
    • pkg/util/strings/string.go
    • pkg/util/nodeops/conditions.go
    • pkg/util/nodeops/taints.go
    • pkg/util/permits/permits_suite_test.go
    • pkg/util/permits/permits_test.go
    • pkg/util/permits/permits.go
    • pkg/util/provider/metrics/metrics.go
    • pkg/util/provider/options/types.go
    • pkg/util/provider/machinecontroller/controller.go
    • pkg/util/provider/machinecontroller/metrics.go
    • pkg/util/provider/machinecontroller/machine_safety_test.go
    • pkg/util/provider/machinecontroller/secret_util.go
    • pkg/util/provider/machinecontroller/machineclass_util.go
    • pkg/util/provider/machinecontroller/machine_test.go
    • pkg/util/provider/machinecontroller/secret.go
    • pkg/util/provider/machinecontroller/machineclass_test.go
    • pkg/util/provider/machinecontroller/machine_util_test.go
    • pkg/util/provider/machinecontroller/machineclass.go
    • pkg/util/provider/machinecontroller/machine_safety.go
    • pkg/util/provider/machinecontroller/secret_test.go
    • pkg/util/provider/machinecontroller/machine.go
    • pkg/util/provider/machinecontroller/controller_suite_test.go
    • pkg/util/provider/machinecontroller/node.go
    • pkg/util/provider/cache/cache.go
    • pkg/util/provider/driver/fake.go
    • pkg/util/provider/driver/driver.go
    • pkg/util/provider/machineutils/utils.go
    • pkg/util/clientbuilder/machine/client_builder.go
    • pkg/util/time/time.go
    • pkg/util/time/time_test.go
    • pkg/util/annotations/annotations_test.go
    • pkg/util/annotations/annotations.go
    • pkg/util/k8sutils/version.go
    • pkg/util/k8sutils/helper.go
    • pkg/features/machine_features.go
    • pkg/controller/deployment_sync_test.go
    • pkg/controller/deployment_util_test.go
    • pkg/controller/controller.go
    • pkg/controller/metrics.go
    • pkg/controller/controller_utils_test.go
    • pkg/controller/machineset_test.go
    • pkg/controller/deployment_rollback_test.go
    • pkg/controller/machine_safety.go
    • pkg/controller/controller_suite_test.go
    • pkg/controller/deployment_test.go
    • pkg/controller/deployment_rolling_test.go
    • pkg/fakeclient/client.go
    • cmd/machine-controller-manager/controller_manager.go
    • cmd/machine-controller-manager/app/controllermanager.go
    • cmd/machine-controller-manager/app/options/options.go
    • pkg/options/helpers.go
    • pkg/util/backoff/wait.go
    • pkg/util/reflector/prometheus/prometheus.go
    • pkg/util/workqueue/prometheus/prometheus.go
    • pkg/util/hash/hash_test.go
    • pkg/util/hash/hash.go
    • pkg/util/labels/labels.go
    • pkg/util/labels/labels_test.go
    • pkg/util/provider/options/helpers.go
    • pkg/util/provider/machinecontroller/machine_util.go
    • pkg/util/provider/machinecontroller/machine_bootstrap_token.go
    • pkg/util/provider/app/app.go
    • pkg/util/provider/app/options/options.go
    • pkg/util/provider/drain/drain_test.go
    • pkg/util/provider/drain/fake_controller.go
    • pkg/util/provider/drain/util.go
    • pkg/util/provider/drain/volume_attachment.go
    • pkg/util/provider/drain/drain.go
    • pkg/util/provider/machinecodes/status/status.go
    • pkg/util/provider/machinecodes/codes/codes.go
    • pkg/util/provider/machinecodes/codes/code_string.go
    • pkg/util/clientbuilder/core/client_builder.go
    • pkg/util/configz/configz.go
    • pkg/util/configz/configz_test.go
    • pkg/util/taints/taints_test.go
    • pkg/util/taints/taints.go
    • pkg/util/client/metrics/prometheus/prometheus.go
    • pkg/util/client/leaderelectionconfig/config.go
    • pkg/controller/deployment.go
    • pkg/controller/deployment_machineset_util.go
    • pkg/controller/deployment_progress.go
    • pkg/controller/controller_ref_manager.go
    • pkg/controller/machineset_util.go
    • pkg/controller/deployment_recreate.go
    • pkg/controller/machineset.go
    • pkg/controller/deployment_sync.go
    • pkg/controller/deployment_rollback.go
    • pkg/controller/controller_utils.go
    • pkg/controller/deployment_rolling.go
    • pkg/controller/deployment_util.go
    • pkg/client/informers/internalversion/factory.go
    • pkg/client/informers/internalversion/generic.go
    • pkg/client/informers/internalversion/internalinterfaces/factory_interfaces.go
    • pkg/client/informers/internalversion/machine/interface.go
    • pkg/client/informers/internalversion/machine/internalversion/interface.go
    • pkg/client/informers/internalversion/machine/internalversion/machinetemplate.go
    • pkg/client/informers/internalversion/machine/internalversion/machineset.go
    • pkg/client/informers/internalversion/machine/internalversion/machineclass.go
    • pkg/client/informers/internalversion/machine/internalversion/machine.go
    • pkg/client/informers/internalversion/machine/internalversion/machinedeployment.go
    • pkg/client/listers/machine/internalversion/machinetemplate.go
    • pkg/client/listers/machine/internalversion/machineset.go
    • pkg/client/listers/machine/internalversion/machineclass.go
    • pkg/client/listers/machine/internalversion/machine.go
    • pkg/client/listers/machine/internalversion/machinedeployment.go
    • pkg/client/listers/machine/internalversion/expansion_generated.go
    • pkg/client/clientset/internalversion/clientset.go
    • pkg/client/clientset/internalversion/doc.go
    • pkg/client/clientset/internalversion/scheme/register.go
    • pkg/client/clientset/internalversion/scheme/doc.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machine_client.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/generated_expansion.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machinetemplate.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machineset.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/doc.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machineclass.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machine.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/machinedeployment.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machinetemplate.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machine_client.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machineclass.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/doc.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machineset.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machine.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_machinedeployment.go
    • pkg/client/clientset/internalversion/typed/machine/internalversion/fake/fake_gcpmachineclass.go
    • pkg/client/clientset/internalversion/fake/register.go
    • pkg/client/clientset/internalversion/fake/clientset_generated.go
    • pkg/client/clientset/internalversion/fake/doc.go
    • pkg/handlers/health.go
    • pkg/handlers/health_test.go

Additional information

  1. To keep this repository compliant, CODEOWNERS must maintain their third party dependencies in the vendor folder using .reuse/dep5 file. To prevent constant maintenance effort, it is highly recommended to remove the vendor folder. In this case no third party dependencies of the vendor folder must be maintained anymore!
  2. NOTICE.md is deleted. If third-party source code is copied, the license/copyright headers must be kept and the copied files should be maintained in .reuse/dep5 file under the section copied source code.
  3. make generate did not generate code for the client in packages pkg/client/informers/*, pkg/client/listers/* and pkg/client/clientset/*. The headers of those generated files are nonetheless modified

@RaphaelVogel RaphaelVogel requested a review from a team as a code owner March 15, 2024 12:09
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Mar 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2024
@RaphaelVogel RaphaelVogel added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 15, 2024
rishabh-11
rishabh-11 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rishabh-11 rishabh-11 self-assigned this Mar 19, 2024
@rishabh-11 rishabh-11 merged commit 10806c2 into gardener:master Mar 19, 2024
8 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 19, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@rishabh-11 rishabh-11

Labels
area/ipcei IPCEI (Important Project of Common European Interest) kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RaphaelVogel @rishabh-11 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot