Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federate non-namespaced metrics #8850

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Federate non-namespaced metrics #8850

merged 1 commit into from
Nov 22, 2023

Conversation

adenitiu
Copy link
Contributor

@adenitiu adenitiu commented Nov 22, 2023

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:
This PR enables the federation of non-namespaced metrics to the aggregate-prometheus. Metrics that would be added are:

kube_node_info
kube_node_labels
kube_node_spec_taint
kube_node_spec_unschedulable
kube_node_status_allocatable
kube_node_status_capacity
kube_node_status_condition
scrape_duration_seconds
scrape_samples_post_metric_relabeling
scrape_samples_scraped
scrape_series_added
up

Which issue(s) this PR fixes:
The interest of this PR is to have more node specific metrics available at the aggregate level.

Special notes for your reviewer:
Discussed this approach with @istvanballok and @rickardsjp .

Release note:

Federate non-namespaced metrics, e.g. kube_node_spec_taint, kube_node_spec_unschedulable. 

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension labels Nov 22, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2023
Copy link
Member

@istvanballok istvanballok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
Copy link
Contributor

gardener-prow bot commented Nov 22, 2023

LGTM label has been added.

Git tree hash: 80077c786700e0e09f869f07b1fc3ca393045ccc

Copy link
Contributor

gardener-prow bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@gardener-prow gardener-prow bot merged commit 13ced1c into gardener:master Nov 22, 2023
@adenitiu adenitiu deleted the patch-1 branch November 22, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants