Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the empty key of storage proof in EIP1186ProofResponse could be deserialized #2754

Merged
merged 2 commits into from Mar 4, 2024
Merged

fix: make the empty key of storage proof in EIP1186ProofResponse could be deserialized #2754

merged 2 commits into from Mar 4, 2024

Conversation

silathdiir
Copy link
Contributor

Close #2753

Motivation

Make the empty key (as 0x) in storage proof could be deserialized.

Solution

Add annotation deserialize_stringified_numeric to the field key of StorageProof.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@silathdiir silathdiir mentioned this pull request Mar 3, 2024
Closed
mattsse
mattsse approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, although empty key is weird.

I guess this would also be the case here

https://github.com/alloy-rs/alloy/blob/main/crates/rpc-types/src/eth/account.rs

@mattsse mattsse merged commit 0644a65 into gakonst:master Mar 4, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to deserialize the empty key of storage proof in EIP1186ProofResponse (for Mainnet)
2 participants
@silathdiir @mattsse