Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases for Base, BaseSepolia and BaseGoerli #2715

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

gabrielstoica
Copy link
Contributor

@gabrielstoica gabrielstoica commented Jan 25, 2024

Motivation

There are no aliases set for Base Mainnet, Sepolia and Goerli.

Solution

Add aliases for Base, BaseGoerli and BaseSepolia and related tests.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@gabrielstoica gabrielstoica changed the title Add aliases for Base Mainnet, Sepolia and Goerli Add aliases for Base, BaseSepolia and BaseGoerli Jan 25, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this
could you please move this to https://github.com/alloy-rs/chains instead

ethers is undergoing deprecation in favor of https://github.com/alloy-rs/alloy

foundry already transitioned to alloy-chains

@gabrielstoica
Copy link
Contributor Author

Hi @mattsse here's the new PR: alloy-rs/chains#32

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 3bf1a9e into gakonst:master Feb 12, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants