Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix EthError decode_with_selector #2698

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix: fix EthError decode_with_selector #2698

merged 1 commit into from
Feb 12, 2024

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Dec 15, 2023

Motivation

The EthError::decode_with_selector function won't work for derived EthError impls, because AbiDecode::decode expects the selector.

Solution

The default impl of EthError::decode_with_selector will call AbiDecode::decode directly.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit b61526f into gakonst:master Feb 12, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blckngm @mattsse