Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable doc_cfg feature for docsrs #2294

Merged
merged 1 commit into from Mar 22, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

This doesn't actually fix the doc problem, since it has to be enabled in generic-array, but it prevents this happening in the future for our crates

Solution

Adds #![cfg_attr(docsrs, feature(doc_cfg))] to all workspace crates (minus examples)

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@gakonst gakonst merged commit 16f9fab into gakonst:master Mar 22, 2023
12 of 16 checks passed
@DaniPopes DaniPopes deleted the fix/enable-cfg-feature branch March 29, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants