Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abigen): handle all struct field types #2289

Merged
merged 2 commits into from Mar 21, 2023
Merged

fix(abigen): handle all struct field types #2289

merged 2 commits into from Mar 21, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Fixes #2287

Solution

Not all patterns were matched

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!
ty

@seunlanlege
Copy link

Any hope we can get this merged today?

@mattsse
Copy link
Collaborator

mattsse commented Mar 21, 2023

cc @gakonst

@gakonst gakonst merged commit 944ed05 into gakonst:master Mar 21, 2023
14 of 16 checks passed
@DaniPopes DaniPopes deleted the fix/abigen-structs branch March 29, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abigen! doesn't support arrays of non-primitive types
4 participants
@DaniPopes @seunlanlege @mattsse @gakonst