Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use to_string in mainnet chain variant #2275

Merged
merged 2 commits into from Mar 17, 2023
Merged

fix: use to_string in mainnet chain variant #2275

merged 2 commits into from Mar 17, 2023

Conversation

CodeSandwich
Copy link
Contributor

@CodeSandwich CodeSandwich commented Mar 17, 2023 •
edited

Motivation

A followup of #2268 in the context of #2270. I didn't trust myself with the serde and strum configurations so I've added a test checking if they match.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

DaniPopes
DaniPopes approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test is already checked in rountrip_string but that's fine

@gakonst gakonst merged commit 1dc5d40 into gakonst:master Mar 17, 2023
13 of 16 checks passed
@CodeSandwich CodeSandwich deleted the patch-2 branch March 18, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeSandwich @DaniPopes @gakonst