Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abigen): fix missing ident # #2267

Merged
merged 1 commit into from Mar 16, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 16, 2023

Motivation

followup to #2263 (review)

forgot a #...

sorry about that @FrankieIsLost

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@gakonst gakonst merged commit 4e6dfe2 into gakonst:master Mar 16, 2023
9 of 12 checks passed
@FrankieIsLost
Copy link
Contributor

Thanks for the quick turnaround here @mattsse . btw, where you able to verify that the toy example in #2261 works with the fix? I built foundry with ethers set to commit 7bf4d25 and looks like I'm still getting the same error.

> forge --version
forge 0.2.0 (030d260 2023-03-16T19:18:25.646781Z)

> forge bind --bindings-path ./bindings --crate-name bindings

> cargo check -p bindings
error[E0433]: failed to resolve: could not find `ethers_core` in the list of imported crates
   --> src/event_emitter.rs:292:9
    |
292 |         ::ethers::contract::EthEvent,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `ethers_core` in the list of imported crates
    |
    = note: this error originates in the derive macro `::ethers::contract::EthEvent` (in Nightly builds, run with -Z macro-backtrace for more info)

This is the branch I used to build foundry https://github.com/FrankieIsLost/foundry/tree/frankie--pull-in-ethers

@FrankieIsLost
Copy link
Contributor

Actually, this might have been resolved in the latest version of ethers, let me confirm before you spend any time on it. Thanks again!

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 16, 2023

I checked after Dani's fix and bindings for event EmptyEvent() compiled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants