Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont poll stream again if done #2245

Merged
merged 1 commit into from Mar 9, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 9, 2023

Motivation

polling a stream after it finished is usually bad.

Solution

only poll if not done

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@gakonst gakonst merged commit 49dccf9 into gakonst:master Mar 9, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants