Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docs.rs build #2221

Merged
merged 2 commits into from Mar 5, 2023
Merged

fix: docs.rs build #2221

merged 2 commits into from Mar 5, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Hopefully

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

mattsse
mattsse approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is due to intra doc links via include! readme that we use both in ethers main and sub crates?

I also tried solving it like this but failed initially.

@DaniPopes
Copy link
Collaborator Author

No, I was going based off of this: https://docs.rs/crate/ethers/1.5.0/builds/755205

@gakonst gakonst merged commit 86a9e7c into gakonst:master Mar 5, 2023
@DaniPopes DaniPopes deleted the fix/docs-rs-abigen branch March 10, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaniPopes @gakonst @mattsse