Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abigen): builtin trait derives #2170

Merged
merged 7 commits into from Feb 21, 2023
Merged

fix(abigen): builtin trait derives #2170

merged 7 commits into from Feb 21, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 20, 2023 •
edited

Motivation

Fixes #2166

Explained in #2166 (comment)

Solution

  1. Add a function that conditionally appends Default and others to the derive list + add multiple versions of seaport in tests
  • also use this function for the generic call/error/event enum
  1. Refactor derive(EthDisplay) to also take the tuple length into account
  2. Improve type detection in ethers-contract-derive due to missing some types + add exhaustive test.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

mattsse
mattsse approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks way cleaner.

lgtm, given that tests still pass

@gakonst gakonst merged commit 3732de8 into gakonst:master Feb 21, 2023
@gakonst
Copy link
Owner

gakonst commented Feb 21, 2023

Thank you @DaniPopes 🤝

@DaniPopes DaniPopes deleted the fix/abigen-builtin-derives branch February 21, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seaport 1.3 ABI-gen not implementing traits
3 participants
@DaniPopes @gakonst @mattsse