Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples #2153

Merged
merged 3 commits into from Feb 14, 2023
Merged

fix: examples #2153

merged 3 commits into from Feb 14, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 14, 2023

Motivation

fixes #2151

Solution

  • abigen example: write bindings env::tmpdir and clear if it exists already
  • gas oracle: create a client even if no api_key env is set since it's not required; use Client::from_env
  • call override: skip executing if geth fails / cannot be found; I tried substituting with Anvil but it doesn't seem to work, presumably because the call override feature is missing from Anvil? @mattsse

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@gakonst gakonst merged commit adefb6c into gakonst:master Feb 14, 2023
@DaniPopes DaniPopes deleted the fix/examples branch February 14, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a few script/examples.sh issues
2 participants