fix(solc): fix autodetection edge case #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/fix-multiple-src-candidates
branch
from
7bda1ed
to
b902160
Compare
gakonst
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes an autodetection edge case where openzepplin wasn't detected:
https://github.com/ScopeLift/flexible-voting/blob/66bd08b74bf983dcbecc0d806d8d98774a0ecfb4/foundry.toml#L7
Solution
updates a check that attempted to find the first
srcdir in a set of candidates to check for the onlysrcdir.the previous check succeeded in opezeppelin dir when it should not.
PR Checklist