Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers): use middleware associated err type #2093

Merged
merged 1 commit into from Jan 30, 2023
Merged

fix(providers): use middleware associated err type #2093

merged 1 commit into from Jan 30, 2023

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Jan 30, 2023

Motivation

Some methods in Middleware were using ProviderError rather than the associated error type.

Solution

Change the following methods on Middleware to use Self::Error instead of ProviderError:

  • import_raw_key
  • unlock_account
  • debug_trace_transaction
  • debug_trace_call

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@Rjected Rjected changed the title feat(core): use middleware associated err type fix(providers): use middleware associated err type Jan 30, 2023
@Rjected Rjected mentioned this pull request Jan 30, 2023
Merged
18 tasks
@gakonst gakonst merged commit 08514ea into gakonst:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rjected @gakonst