Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add getrandom with js feature for wasm #2076

Merged
merged 1 commit into from Jan 27, 2023
Merged

fix: add getrandom with js feature for wasm #2076

merged 1 commit into from Jan 27, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 25, 2023

Motivation

getrandom needs to be enabled with js feature when for wasm target

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

gakonst
gakonst approved these changes Jan 27, 2023
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof how was this not caught before -_-

@gakonst gakonst merged commit ff05a87 into gakonst:master Jan 27, 2023
@ufoscout ufoscout mentioned this pull request Feb 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst