Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsdoc/require-description-complete-sentence] Inline JSDoc tags at the start of a sentence cause lint to fail #1150

Closed
jnbooth opened this issue Aug 30, 2023 · 2 comments · Fixed by #1157

Comments

@jnbooth
Copy link

jnbooth commented Aug 30, 2023

This is similar to #705, but regarding capitalization at the start of a sentence rather than punctuation at the end of it.

Expected behavior

If a JSDoc comment starts with an inline {@link} tag, jsdoc/require-description-complete-sentence should not fail as long as the text starts with a capital letter and ends with a period.

Actual behavior

The above code sample fails jsdoc/require-description-complete-sentence because the linting rule thinks the description starts with {, which is not a capital letter.

ESLint Config

{
  "plugins": ["jsdoc"],
  "rules": {
   "jsdoc/require-description-complete-sentence": ["error"]
  }
}

ESLint sample

/** @param options {@link RequestOptions} specifying path parameters and query parameters. */

Environment

  • Node version: 18.16.0
  • ESLint version 8.18.0
  • eslint-plugin-jsdoc version: 46.2.6
@brettz9
Copy link
Collaborator

brettz9 commented Sep 14, 2023

I think we should just blanket permit inline tags at the beginning of a sentence. Besides the link possibly being a URL, it may be a variable name or such and not call for capitalization, so I think we should just allow any inline tags at the beginning.

brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Sep 14, 2023
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Sep 14, 2023
brettz9 added a commit that referenced this issue Sep 15, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 46.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants