Fix infinite loop bug (#252)

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
fusesource · Aug 25, 2023 · c3ac54f · c3ac54f
1 parent 58260c6
commit c3ac54f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/main/java/org/fusesource/jansi/Ansi.java b/src/main/java/org/fusesource/jansi/Ansi.java
@@ -703,10 +703,16 @@ public Ansi eraseLine(final Erase kind) {
     }
 
     public Ansi scrollUp(final int rows) {
+        if (rows == Integer.MIN_VALUE) {
+            return scrollDown(Integer.MAX_VALUE);
+        }
         return rows > 0 ? appendEscapeSequence('S', rows) : rows < 0 ? scrollDown(-rows) : this;
     }
 
     public Ansi scrollDown(final int rows) {
+        if (rows == Integer.MIN_VALUE) {
+            return scrollUp(Integer.MAX_VALUE);
+        }
         return rows > 0 ? appendEscapeSequence('T', rows) : rows < 0 ? scrollUp(-rows) : this;
     }
 

diff --git a/src/test/java/org/fusesource/jansi/AnsiTest.java b/src/test/java/org/fusesource/jansi/AnsiTest.java
@@ -67,6 +67,24 @@ public void apply(Ansi ansi) {
                         .toString());
     }
 
+    @ParameterizedTest
+    @CsvSource({
+        "-2147483648,ESC[2147483647T", "2147483647,ESC[2147483647S",
+        "-100000,ESC[100000T", "100000,ESC[100000S"
+    })
+    public void testScrollUp(int x, String expected) {
+        assertAnsi(expected, Ansi.ansi().scrollUp(x));
+    }
+
+    @ParameterizedTest
+    @CsvSource({
+        "-2147483648,ESC[2147483647S", "2147483647,ESC[2147483647T",
+        "-100000,ESC[100000S", "100000,ESC[100000T"
+    })
+    public void testScrollDown(int x, String expected) {
+        assertAnsi(expected, Ansi.ansi().scrollDown(x));
+    }
+
     @ParameterizedTest
     @CsvSource({
         "-1,-1,ESC[1;1H", "-1,0,ESC[1;1H", "-1,1,ESC[1;1H", "-1,2,ESC[1;2H",