Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to character in ASTTransformer #3077

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

ErikSchierboom
Copy link
Contributor

Closes #3076

Please verify your pull request is respecting our Pull request ground rules.
You can find more information in our Contributors documentation section.

Copy link
Contributor Author

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created this as a draft as I had a question.

src/Fantomas.Core.Tests/FormatAstTests.fs Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Contributor Author

The build is failing due to a formatting issue. What is the best way to fix this?

@dawedawe
Copy link
Member

The build is failing due to a formatting issue. What is the best way to fix this?

dotnet fantomas .\src\ should be enough

src/Fantomas.Core/ASTTransformer.fs Fixed Show resolved Hide resolved
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks.
If you want a new release with this fix, you can add an entry to the changelog.md file

src/Fantomas.Core.Tests/FormatAstTests.fs Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Contributor Author

I've updated the changelog and asked one last question.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/Fantomas.Core.Tests/FormatAstTests.fs Outdated Show resolved Hide resolved
ErikSchierboom and others added 2 commits April 12, 2024 15:11

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
@ErikSchierboom ErikSchierboom marked this pull request as ready for review April 12, 2024 13:12
@ErikSchierboom ErikSchierboom requested a review from nojaf April 12, 2024 13:12
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik!

@nojaf nojaf merged commit ccaee4a into fsprojects:main Apr 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatASTAsync loses single quotes for characters
3 participants