Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC on https://github.com/paulmillr/chokidar/pull/1197 #374

Open
MarcCelani-at opened this issue Mar 27, 2022 · 4 comments
Open

RFC on https://github.com/paulmillr/chokidar/pull/1197 #374

MarcCelani-at opened this issue Mar 27, 2022 · 4 comments

Comments

@MarcCelani-at
Copy link

In paulmillr/chokidar#1197, the maintainer of chokidar asked if chokidar or fsevents is the right layer to handle when macOS reports kFSEventStreamEventFlagMustScanSubDirs. Can the maintainer please comment there or here?
@MarcCelani-at MarcCelani-at mentioned this issue Mar 30, 2022
Merged
@MarcCelani-at
Copy link
Author

Hi folks, wondering if someone can take a look at this and offer some feedback?

@paulmillr
Copy link
Member

cc @pipobscure

@MarcCelani-at
Copy link
Author

Would love someone to take a look here, please.

@pipobscure
Copy link
Contributor

In all truth, there is no longer a reason that chokidar should use the fsevents module any longer.

libuv has been using the fsevents mac technology for a while now such that there is now no supported node version that doesn’t have it. That means in the context of file watching this is now entirely superfluous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pipobscure @paulmillr @MarcCelani-at