Set MSRV in Cargo.toml to 1.58.1
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crate does not build with rustc 1.57.0 while it does with rustc 1.58.1.
luke-biel
requested changes
Feb 14, 2023
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "test-case" | |||
| version = "3.0.0" | |||
| edition = "2018" | |||
| edition = "2021" | |||
There was a problem hiding this comment.
We should also bump edition in crates/test-case-macros and crates/test-case-core.
There was a problem hiding this comment.
Done in all crates in the repository.
The MSRV for this crate is rustc 1.58.1 which supports Rust 2021.
samueltardieu
force-pushed
the
set-msrv
branch
from
9107ca6
to
9d41891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the MSRV in
Cargo.tomlhelps various tools to check if they can use a particular version of a crate.The current lowest compiler with wich test-case currently builds is 1.58, this is the version I used in
Cargo.toml. However, note that to run succesfully tests require a recent version.Since 1.58.1 is a 2021 edition compiler, I bumped the edition to 2021 as well.
I've added a Github Actions job to check that the crate can be built (but not tested) with the documented MSRV.
I suggest later moving to https://github.com/dtolnay/rust-toolchain which supports using toolchains such as "stable minus 2 releases" which seems to meet test-case's published goals.