Simplify backtrace-related assertions #680
Merged
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `ExecutionPoint` already stores the full backtrace, we should already have it in the format for the relevant Ruby version. Using this is a lot simpler than having to generate the line from scratch.
Since the `Expectation` instance already "knows" where it was defined, it's simpler to use `Expectation#definition_location` to make these assertions. And again, since this is obtained directly from the backtrace, it should be in the format for the relevant Ruby version.
floehopper
pushed a commit
that referenced
this pull request
Dec 7, 2024
Since this change [1], lines in the stacktrace use an opening
single-quote instead of a backtick to delimit the method name, e.g.
foo.rb:5:in 'Foo#bar': boom! (RuntimeError)
Instead of:
foo.rb:5:in `Foo#bar': boom! (RuntimeError)
This commit makes a relevant assertion specific to the current Ruby
version.
This is somewhat similar to the fixes I put in place in #672, although
those were later considerably simplified in #680. Unfortunately I can't
see a way to achieve a similar simpification in this case.
[1]: https://bugs.ruby-lang.org/]issues/16495
floehopper
pushed a commit
that referenced
this pull request
Dec 7, 2024
Since this change [1], lines in the stacktrace use an opening
single-quote instead of a backtick to delimit the method name, e.g.
foo.rb:5:in 'Foo#bar': boom! (RuntimeError)
Instead of:
foo.rb:5:in `Foo#bar': boom! (RuntimeError)
This commit makes a relevant assertion specific to the current Ruby
version.
This is somewhat similar to the fixes I put in place in #672, although
those were later considerably simplified in #680. Unfortunately I can't
see a way to achieve a similar simpification in this case.
[1]: https://bugs.ruby-lang.org/]issues/16495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were generating the expected backtrace-related strings from scratch, but that was (a) quite complicated; and (b) suffered from Ruby version differences. Now we're using strings obtained directly from a Ruby backtrace which is a lot simpler and avoids the Ruby version differences.