Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ruby 1.9 hash syntax #598

Merged
merged 1 commit into from Dec 25, 2022
Merged

Use Ruby 1.9 hash syntax #598

merged 1 commit into from Dec 25, 2022

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Dec 22, 2022

Fixes #537

@floehopper
Copy link
Member

@herwinw This looks good to me. The CI build failure is a known JRuby issue which should be fixed soon. Can you just confirm that you used Rubocop's auto-correct functionality to make these changes...? Thanks.

@herwinw
Copy link
Contributor Author

herwinw commented Dec 25, 2022

I did use the auto-correct, and afterwards I checked the diff manually to see if it still looked sensible (since occasionally the auto-correct screws things up)

@floehopper floehopper merged commit 8bc0ad2 into freerange:main Dec 25, 2022
@herwinw herwinw deleted the ruby_1_9_hash_syntax branch December 25, 2022 19:26
@floehopper
Copy link
Member

This was released in v2.0.3.

floehopper added a commit that referenced this pull request Nov 12, 2023
@floehopper
Use Ruby v1.9 Hash syntax in docs
27771c4 
We updated the code to use Ruby v1.9 Hash syntax in #598. This brings
the docs into line with that change.

Fixes #625.
@floehopper floehopper mentioned this pull request Nov 12, 2023
Merged
floehopper added a commit that referenced this pull request Nov 12, 2023
@floehopper
Use Ruby v1.9 Hash syntax in docs
6de2072 
We updated the code to use Ruby v1.9 Hash syntax in #598. This brings
the docs into line with that change.

Fixes #625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Ruby v1.9 Hash literal syntax
2 participants
@herwinw @floehopper