Fix detection of missing done in Defer from Defer #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a failing test for a 'missing Done' detection failure: a Defer called from a defered function must have another matching Done.
Refactor Defer to make clearer that running the defered function is just delegated to Cleanup. The 'Done called' hook is now installed in its own Cleanup. Note that the panic about missing Done call will now also happen after the run of the last deferred function. Also it will be correctly installed multiple times for the weired case where Defer() is called from a deferred function.
dolmen
force-pushed
the
fix-detection-of-missing-Done-in-Defer-from-Defer
branch
from
8ec573f
to
3ecf279
Compare
frankban
approved these changes
Jun 10, 2023
|
Released as v1.14.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a case where a missing call to Done following Defer wasn't detected: the (weired) case where Defer is called from a defered function.
First commit is the failing test.
Second commit is the fix. It also refactors the detection by using two separate calls to TB.Cleanup: one to defer the function, one for the 'missing Done' detection.