Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieval time of parent's Format when starting a subtest #157

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 8, 2023

When starting a subtest, retrieve the parent Checker's Format synchronously before c.Run is called instead of when the test engine really starts running the subtest.

When starting a subtest, retrieve the parent Checker's Format
synchronously when c.Run is called instead of when the test engine
really starts running the subtest.
Copy link
Owner

@frankban frankban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization, thanks!

@frankban frankban merged commit 821de06 into frankban:master Jun 10, 2023
8 checks passed
@frankban
Copy link
Owner

frankban commented Aug 1, 2023

Released as v1.14.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants