Allow animation startTime to be set manually
#2755
Merged
+195
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgperry
changed the base branch from
main
to
fix/keyframe-resolve-external-motion-value
mattgperry
force-pushed
the
fix/keyframe-resolve-external-motion-value
branch
from
29eb5bd to
bbd4436
Compare
mattgperry
force-pushed
the
feature/supersync
branch
from
4adcdbd to
84e978b
Compare
adamseckel
reviewed
Aug 13, 2024
Comment on lines
+276
to
+278
| // Coerce to number as TypeScript incorrectly types this | ||
| // as CSSNumberish | ||
| return animation.startTime as number |
There was a problem hiding this comment.
Is this just a typescript problem or would a simple if (!isNumber(animation.startTime)) return null be more future proof?
There was a problem hiding this comment.
Web Animations L2 spec does show times as CSSNumberish but it isn't ready yet so could still be changed - I also struggle believing they will make this backwards incompatible
adamseckel
approved these changes
Aug 13, 2024
mattgperry
force-pushed
the
fix/keyframe-resolve-external-motion-value
branch
from
22b1317 to
ac31a7f
Compare
Base automatically changed from
fix/keyframe-resolve-external-motion-value
to
main
August 14, 2024 12:54
…ided MotionValues
mattgperry
force-pushed
the
feature/supersync
branch
from
d11b770 to
c71a6be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
startTimeof an animation to be set manually viaoptions.A subsequent PR will use this to better sync animations to optimised appear animations.