Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding stop() to animation #2635

Merged
merged 1 commit into from Apr 19, 2024
Merged

Binding stop() to animation #2635

merged 1 commit into from Apr 19, 2024

Conversation

mattgperry
Copy link
Collaborator

This PR binds stop to the animation to fix a pattern where animation.stop is passed back from useEffect.

useEffect(() => {
  const animation = animate()
  return animation.stop
})

@mattgperry mattgperry requested a review from nvh April 19, 2024 12:27
Copy link
Contributor

@nvh nvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodidea

@mattgperry mattgperry self-assigned this Apr 19, 2024
@mattgperry mattgperry added the automerge Land this PR label Apr 19, 2024
@mattgperry mattgperry removed their assignment Apr 19, 2024
@mergetron mergetron bot merged commit 0d72893 into main Apr 19, 2024
1 check passed
@mergetron mergetron bot deleted the fix/bound-stop branch April 19, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Land this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants