Add $$typeof
brand back to ForwardRefComponent
#2631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to Framer's
ForwardRefComponent
type breaks compatibility withReact.ForwardRefExoticComponent
due to a missing property$$typeof
, which lives onReact.ExoticComponent
.This means that Framer's
motion
components won't be accepted in contexts calling for a standardForwardRefExoticComponent
. See below:Working in
framer-motion@11.1.3
, but breaks inframer-motion@11.1.4
With this change,
ForwardRefComponent
's type behaves as normal, and can retain theJSX.Element
return type while better supporting React's type implementation.