Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve useInstantTransition #2198

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Improve useInstantTransition #2198

merged 2 commits into from
Jun 23, 2023
+60 −2

Conversation

adamseckel
Copy link
Collaborator

@adamseckel adamseckel commented Jun 22, 2023 •
edited
Loading

useInstantTransition can get into a bad state if its callback is called in subsequent frames.

@adamseckel adamseckel requested a review from shuangq June 22, 2023 16:20
shuangq
shuangq approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@shuangq shuangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to capture this issue in a test?

@adamseckel
Copy link
Collaborator Author

Is it possible to capture this issue in a test?

Wondering the same. Let me see if there are test utilities to run the frames in a controlled way 🤔

@mergetron mergetron bot merged commit 90e5b1c into main Jun 23, 2023
@mergetron mergetron bot deleted the fix/use-instant-transition branch June 23, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuangq shuangq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamseckel @shuangq