Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node20 in action. #37

Merged
merged 6 commits into from Feb 14, 2024
Merged

Use node20 in action. #37

merged 6 commits into from Feb 14, 2024

Conversation

csasarak
Copy link
Contributor

@csasarak csasarak commented Feb 14, 2024 •
edited

GHA is deprecating Node 16 in spring 2024. This updates our action to run using Node 20.

@csasarak csasarak marked this pull request as ready for review February 14, 2024 19:51
@csasarak csasarak requested a review from a team as a code owner February 14, 2024 19:51
@csasarak csasarak requested review from meghfossa and removed request for a team February 14, 2024 19:51
@meghfossa
Copy link
Contributor

@csasarak - Is there a way to test changes? I'm presuming this would apply to all end users depending on this action currently?

@csasarak
Copy link
Contributor Author

@meghfossa I think it would only if they were using main and not pinning a released version. The workflow that ran on this PR runs the action several times with different options. Can you say more about what you mean with "test changes"?

@meghfossa
Copy link
Contributor

@meghfossa I think it would only if they were using main and not pinning a released version. The workflow that ran on this PR runs the action several times with different options. Can you say more about what you mean with "test changes"?

I misread the PR - this is only changing the "Github action node", not the node version, when users use GH Action. ✅

@csasarak csasarak merged commit 32c7979 into main Feb 14, 2024
1 check passed
@csasarak csasarak deleted the use-node-20 branch February 14, 2024 21:33
@djbrown djbrown mentioned this pull request Mar 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meghfossa meghfossa meghfossa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csasarak @meghfossa